BuddiesOfBudgie/budgie-desktop-services
5
0
Fork 1
Code Issues 1 Pull requests Projects Releases 2 Activity Actions

dbus: Don't pre-generate DBus classes #21

Merged
ngompa merged 1 commit from autogenerate-dbus-classes into main 2025-12-17 10:26:40 +01:00
Conversation 5 Commits 1 Files changed 21 +95 -974
EbonJaeger commented 2025-12-15 23:30:00 +01:00
Owner
Copy link

This PR replaces the in source generated dbus files with files created from the schema XML files.

Supplants #19

Fixes #17

Signed-off-by: Evan Maddock maddock.evan@vivaldi.net

This PR replaces the in source generated dbus files with files created from the schema XML files. Supplants https://forge.moderndesktop.dev/BuddiesOfBudgie/budgie-desktop-services/pulls/19 Fixes https://forge.moderndesktop.dev/BuddiesOfBudgie/budgie-desktop-services/issues/17 Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
This PR replaces the in source generated dbus files with files created from the schema XML files.

Supplants #19

Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
ngompa requested changes 2025-12-16 00:23:25 +01:00
Dismissed
src/main.cpp Outdated
@ -36,0 +43,4 @@
if (!manager) return;
if (!QDBusConnection::sessionBus().registerService("org.buddiesofbudgie.BudgieDaemon")) {
ngompa commented 2025-12-16 00:23:21 +01:00
Owner
Copy link

Is it still org.buddiesofbudgie.BudgieDaemon? I thought we renamed this...

Is it still `org.buddiesofbudgie.BudgieDaemon`? I thought we renamed this...
EbonJaeger commented 2025-12-16 01:09:46 +01:00
Author
Owner
Copy link

Oops, good catch. Fixed!

Oops, good catch. Fixed!
ngompa marked this conversation as resolved
EbonJaeger force-pushed autogenerate-dbus-classes from 10a15967e0 to 6f4cc87ce6 2025-12-16 01:09:28 +01:00 Compare
ngompa approved these changes 2025-12-16 01:22:57 +01:00
Dismissed
ngompa commented 2025-12-16 01:24:03 +01:00
Owner
Copy link

Should the commit message have Supplants #19 in it? Usually these tags are really only useful in the pull request description.

Should the commit message have `Supplants #19` in it? Usually these tags are really only useful in the pull request description.
ngompa requested changes 2025-12-16 09:51:05 +01:00
Dismissed
ngompa left a comment
Owner
Copy link

The commit message should drop the Supplants stanza since it doesn't make sense there.

The commit message should drop the `Supplants` stanza since it doesn't make sense there.
EbonJaeger force-pushed autogenerate-dbus-classes from 6f4cc87ce6 to 0363453250 2025-12-16 19:04:20 +01:00 Compare
ngompa approved these changes 2025-12-17 10:26:04 +01:00
ngompa merged commit 0363453250 into main 2025-12-17 10:26:40 +01:00
ngompa deleted branch autogenerate-dbus-classes 2025-12-17 10:26:45 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
ngompa
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
BuddiesOfBudgie/budgie-desktop-services!21
No description provided.