Use of precompiled headers #17
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
BuddiesOfBudgie/budgie-desktop-services#17
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
From a review by Debian,
The use of precompiled headers stored in the source itself causes licensing questions - who's license is it because its not actually fully fleshed out in the source file. At the moment the tooling I've used thinks the license is
"Files: src/dbus/generated/*
Copyright: The Qt Company Ltd. and other contributors.
License: MPL-2.0"
I've added the MPL-2.0 License here since the tooling didn't know.
"Could the src/dbus/generated/* files be generated ... by the upstream build system (for
everyone [i.e. during the build itself]) instead of being generated by Taskfile.yml and checked in to
git."
Generated files don't hold the Qt Company copyright, they are either copyright-free or have ours.
The tooling is confused because there's a notice in the header about what tool made it and who owns the copyright of the tool. Just ignore it for
debian/copyrightpurposes.The generated files specifically have a copyright statement - we can't assume otherwise. I can only assume Debian takes a literal interpretation here given that its in the source. https://forge.moderndesktop.dev/BuddiesOfBudgie/budgie-desktop-services/src/branch/main/src/dbus/generated/BatchSystemAdaptorGen.h
random google led me to this - dunno if it helps https://forum.qt.io/topic/48426/reference-generated-dbus-interface-files - went over my head.
@fossfreedom wrote in #17 (comment):
No? The exact statement in the header is about the tool used to make it, not the file itself.
Yes the header is generated by qdbusxml2cpp as noted by Neal. It is explaining the copyright owner of the tool, it is not communicating any other copyright.