BuddiesOfBudgie/budgie-desktop-services
5
0
Fork 1
Code Issues 6 Pull requests Projects Releases 5 Activity Actions

fix(outputs): missing stateChanged emits on changing of various props #25

Merged
EbonJaeger merged 1 commit from fix/missing-metahead-statechanged-calls into main 2026-01-13 18:54:17 +01:00
Conversation 1 Commits 1 Files changed 1 +3
JoshStrobl commented 2026-01-13 18:50:17 +01:00
Owner
Copy link

User Story

I tried to change the scale of my monitor to 2.0, however it did not get updated in the configuration file. Subsequent reboots changed it back to 1.0.

Resolution

Added missing stateChanged emits on the following properties to resolve the State::checkAndEmitSignals slot not being fired:

  • AdaptiveSync
  • Scale
  • Transform

Previously, it was only being fired on:

  • Enabled
  • Position

Fixes #24

## User Story I tried to change the scale of my monitor to 2.0, however it did not get updated in the configuration file. Subsequent reboots changed it back to 1.0. ## Resolution Added missing stateChanged emits on the following properties to resolve the State::checkAndEmitSignals slot not being fired: - AdaptiveSync - Scale - Transform Previously, it was only being fired on: - Enabled - Position Fixes #24
fix(outputs): missing stateChanged emits on changing of various props
All checks were successful
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
b306e868b3 
## User Story

I tried to change the scale of my monitor to 2.0, however it did not get updated in the configuration file. Subsequent reboots changed it back to 1.0.

## Resolution

Added missing stateChanged emits on the following properties to resolve the State::checkAndEmitSignals slot not being fired:

- AdaptiveSync
- Scale
- Transform

Previously, it was only being fired on:

- Enabled
- Position

Fixes #24
EbonJaeger approved these changes 2026-01-13 18:53:59 +01:00
EbonJaeger left a comment
Owner
Copy link

LGTM, thanks!

LGTM, thanks!
EbonJaeger deleted branch fix/missing-metahead-statechanged-calls 2026-01-13 18:54:17 +01:00
JoshStrobl added this to the (deleted) project 2026-01-13 19:37:43 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
EbonJaeger
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
for-next-chirp

This issue or pull request should be discussed in the next Buddies of Budgie "Chirp".

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
for-next-chirp
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
JoshStrobl
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
BuddiesOfBudgie/budgie-desktop-services!25
No description provided.