BuddiesOfBudgie/budgie-display-configurator
5
0
Fork 0
Code Issues Pull requests Projects Releases 1 Activity Actions

build: Re-organize CMake files #1

Merged
JoshStrobl merged 1 commit from cmake-changes into main 2025-10-21 18:44:50 +02:00
Conversation 4 Commits 1 Files changed 4 +50 -33
EbonJaeger commented 2025-10-20 18:54:06 +02:00
Owner
Copy link

This makes the CMake structure more like other CMake projects. This should make it easier to work with if/when new parts or modules are added to the project.

Changes:

  • Required dependencies are declared in the root
  • Desktop file is installed by the root CMake file
  • Remove unused dependency on KIconTheme
  • Remove INCLUDE_QUIET_PACKAGES from the summary (See https://github.com/EbonJaeger/bluejay/pull/42. It's also steadily being removed from other KDE projects.)
This makes the CMake structure more like other CMake projects. This should make it easier to work with if/when new parts or modules are added to the project. Changes: - Required dependencies are declared in the root - Desktop file is installed by the root CMake file - Remove unused dependency on KIconTheme - Remove `INCLUDE_QUIET_PACKAGES` from the summary (See https://github.com/EbonJaeger/bluejay/pull/42. It's also steadily being removed from other KDE projects.)
This makes the CMake structure more like other CMake projects. This
should make it easier to work with if/when new parts or modules are
added to the project.

Changes:

- Required dependencies are declared in the root
- Desktop file is installed by the root CMake file
- Remove unused dependency on KIconTheme
- Remove `INCLUDE_QUIET_PACKAGES` from the summary (See
  https://github.com/EbonJaeger/bluejay/pull/42. It's also steadily
  being removed from other KDE projects.)

Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
ngompa approved these changes 2025-10-20 18:57:02 +02:00
EbonJaeger changed title from build: Re-organize CMake files to WIP: build: Re-organize CMake files 2025-10-20 19:00:58 +02:00
EbonJaeger commented 2025-10-20 19:01:30 +02:00
Author
Owner
Copy link

Marking as WIP, since I discovered more CMake stuff in the backend dir that I want to go through.

Marking as WIP, since I discovered more CMake stuff in the backend dir that I want to go through.
EbonJaeger changed title from WIP: build: Re-organize CMake files to build: Re-organize CMake files 2025-10-20 19:09:37 +02:00
EbonJaeger commented 2025-10-20 19:09:50 +02:00
Author
Owner
Copy link

I think I want to tackle backend in a separate PR.

I think I want to tackle `backend` in a separate PR.
JoshStrobl approved these changes 2025-10-21 18:44:42 +02:00
JoshStrobl left a comment
Owner
Copy link

LGTM, thanks!

LGTM, thanks!
EbonJaeger deleted branch cmake-changes 2025-10-21 19:34:36 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
ngompa
JoshStrobl
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#2 Reorganize the backend directory
BuddiesOfBudgie/budgie-display-configurator
Reference
BuddiesOfBudgie/budgie-display-configurator!1
No description provided.