ModernDesktopInitiative/koto
4
0
Fork 0
Code Issues 17 Pull requests Projects Releases Packages Wiki Activity Actions

Implement double-click logic in our Track Table to immediately start playback of track and respective playlist.

Browse source 
Rewrote some legacy KotoCurrentPlaylist code that relied on communicating KotoPlaylist change via a property change. Changed to using a signal.

Implemented new koto_album_create_playlist function so we can use our KotoPlaylist generation in the KotoActionBar. Prior to this change, clicking "Play" on a given track in a DiscView would only play that specific track and never give you the opportunity to go backwards or forwards. Now we will use our "continue on playlist" config to determine that behaviour and dynamically generate a playlist when the actionbar is relative to an Album. This functionality is leveraged with a change to koto_current_playlist_set_playlist that now requires a gboolean for determining if we should play immediately as well.

Added type checks in our KotoPlayerbar progress / range usage. Prior to this change, you would get a (harmless) GLib Warning when closing the application.

Fixed KotoPlayerbar info updating returning early when it failed to get an Album for a track, resulting in the artwork never being reset.

Fixed multiple warnings when missing metadata and using g_variants in our koto_playback_set_track_by_uuid.
This commit is contained in:
Joshua Strobl 2021-07-10 01:20:20 +03:00
parent d8b71b8548
commit ca4873e07f
13 changed files with 265 additions and 142 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/playback/engine.h
View file

@ -52,10 +52,11 @@ void koto_playback_engine_apply_configuration_state(
void koto_playback_engine_backwards(KotoPlaybackEngine * self);
void koto_playback_engine_current_playlist_changed(
void koto_playback_engine_handle_current_playlist_changed(
KotoCurrentPlaylist * current_pl,
guint prop_id,
KotoPlaybackEngine * self
KotoPlaylist * playlist,
gboolean play_immediately,
gpointer user_data
);
void koto_playback_engine_forwards(KotoPlaybackEngine * self);