build: Redo CMake files, using normal KDE conventions #2

Merged

EbonJaeger merged 1 commit from redo-cmake-files into main

2025-03-19 17:34:38 +01:00

EbonJaeger commented

2025-03-17 19:16:36 +01:00

(Migrated from github.com)

This completely overhauls the CMake build files, resulting in a cleaner and more readable build system.

One thing to note is that we can't currently use the KDE compiler settings module without doing significant work to the entire codebase. I think we should definitely work on enabling it, as it turns on more warnings, and uses stricter settings, which should result in us having a safer codebase.

At the very least, this compiles.

This completely overhauls the CMake build files, resulting in a cleaner and more readable build system. One thing to note is that we can't currently use the [KDE compiler settings module](https://api.kde.org/ecm/kde-module/KDECompilerSettings.html) without doing significant work to the entire codebase. I think we should definitely work on enabling it, as it turns on more warnings, and uses stricter settings, which should result in us having a safer codebase. At the very least, this compiles.

Conan-Kudo (Migrated from github.com) requested changes

2025-03-17 19:29:04 +01:00

Conan-Kudo (Migrated from github.com) left a comment

What's with the commented out stuff?

JoshStrobl (Migrated from github.com) approved these changes

2025-03-17 19:32:55 +01:00

JoshStrobl (Migrated from github.com) left a comment

LGTM, thanks! 💯

JoshStrobl commented

2025-03-17 19:34:12 +01:00

(Migrated from github.com)

@Conan-Kudo that's from me testing out systemd service unit bits however I ended up commenting it out as labwc has a different mechanism for launching applications that ensures they are done after the compositor is up and running.

JoshStrobl commented

2025-03-17 19:35:29 +01:00

(Migrated from github.com)

Of course we could have it as a CMAKE option with labwc defaulted to ON, then when off it'll add the service files but in practice we'll need something for alternative compositors anyways. Maybe we can ensure it's launched when WAYLAND_DISPLAY is set? 🤔

EbonJaeger commented

2025-03-17 20:28:14 +01:00

(Migrated from github.com)

I added two options that both default to ON:

INSTALL_SERVICE_FILES
INSTALL_LABWC

You may have to nuke and re-configure your build directory for it to correctly pick up the defaults.

I added two options that both default to **ON**: - `INSTALL_SERVICE_FILES` - `INSTALL_LABWC` You may have to nuke and re-configure your build directory for it to correctly pick up the defaults.